[PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to search path.

  • Done
  • quality assurance status badge
Details
2 participants
  • Alex Vong
  • Ludovic Courtès
Owner
unassigned
Submitted by
Alex Vong
Severity
normal

Debbugs page

A
A
Alex Vong wrote on 2 Mar 2018 05:59
(address . guix-patches@gnu.org)(address . alexvong1995@gmail.com)
87woyuk28k.fsf@gmail.com
Hello,

This patch should fix https://bugs.gnu.org/30641.
From 2ad112584b40754fadb8269b7d5880500abe0050 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Fri, 2 Mar 2018 21:22:59 +0800
Subject: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
search path.

Reported by Ricardo Wurmus <rekado@elephly.net>.

* gnu/packages/video.scm (youtube-viewer)[arguments]: In 'wrap-program'
phase, add '$out/lib/perl5/site_perl/' to search path.
---
gnu/packages/video.scm | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 8190b0ffc..74dd290a3 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1344,16 +1344,18 @@ audio, images) from the Web. It can use either mpv or vlc for playback.")
(guix build utils)
(srfi srfi-26))
#:module-build-flags '("--gtk")
- #:phases (modify-phases %standard-phases
- (add-after 'install 'wrap-program
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((bin-dir (string-append (assoc-ref outputs "out")
- "/bin/"))
- (perl-path (getenv "PERL5LIB")))
- (for-each (cut wrap-program <>
- `("PERL5LIB" ":" prefix (,perl-path)))
- (find-files bin-dir))
- #t))))))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'wrap-program
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin-dir (string-append out "/bin/"))
+ (site-dir (string-append out "/lib/perl5/site_perl/"))
+ (lib-path (getenv "PERL5LIB")))
+ (for-each (cut wrap-program <>
+ `("PERL5LIB" ":" prefix (,lib-path ,site-dir)))
+ (find-files bin-dir))
+ #t))))))
(synopsis
"Lightweight application for searching and streaming videos from YouTube")
(description
--
2.16.2
Cheers,
Alex
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQTdXC2pN4kXBjiMDs8cGaIXrbrArQUCWplYqwAKCRAcGaIXrbrA
rd1xAP0WH5dlwvwesUtgxc40+8DYpO/1HoSvAHpYlFnDmUD0FwD/eA9oKL9tappR
taZvpLY18N3Jf4Y3mSk06zraoc3+jgo=
=Qy/j
-----END PGP SIGNATURE-----

A
A
Alex Vong wrote on 2 Mar 2018 06:03
(address . guix-patches@gnu.org)(address . alexvong1995@gmail.com)
87o9k6k218.fsf@gmail.com
Alex Vong <alexvong1995@gmail.com> writes:

Toggle quote (4 lines)
> Hello,
>
> This patch should fix <https://bugs.gnu.org/30641>.
>
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQTdXC2pN4kXBjiMDs8cGaIXrbrArQUCWplZswAKCRAcGaIXrbrA
rWWZAQCoL8RmA8b0dXB0qaV7nraocgyl5JXD8T79wniAcUgXWQD+KiPGqk+20xiF
YqycoCWr6K/iUh5wVnJtbjcY3jO89QA=
=OqPr
-----END PGP SIGNATURE-----

A
A
Alex Vong wrote on 2 Mar 2018 06:08
(address . guix-patches@gnu.org)(address . alexvong1995@gmail.com)
87k1uuk1th.fsf@gmail.com
Alex Vong <alexvong1995@gmail.com> writes:

Toggle quote (8 lines)
> Alex Vong <alexvong1995@gmail.com> writes:
>
>> Hello,
>>
>> This patch should fix <https://bugs.gnu.org/30641>.
>>
> Sorry, I mean <https://debbugs.gnu.org/30677>.

In fact, it should be https://debbugs.gnu.org/30671.
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQTdXC2pN4kXBjiMDs8cGaIXrbrArQUCWplaygAKCRAcGaIXrbrA
rdCHAQCpF5oGC6h3tOjd1Q8FlVSFcq38IxhJUSw1vfJ2jkuJZQEA31eHEP2TM0ad
OFwrm3kgJ33J+VWCcPx6MkSlwo53Fgc=
=hFTO
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 7 Mar 2018 02:24
Re: [bug#30677] [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to search path.
(name . Alex Vong)(address . alexvong1995@gmail.com)(address . 30677@debbugs.gnu.org)
87zi3ktc8p.fsf@gnu.org
Alex Vong <alexvong1995@gmail.com> skribis:

Toggle quote (12 lines)
> From 2ad112584b40754fadb8269b7d5880500abe0050 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Fri, 2 Mar 2018 21:22:59 +0800
> Subject: [PATCH] gnu: youtube-viewer: Add '$out/lib/perl5/site_perl/' to
> search path.
>
> Fixes <https://bugs.gnu.org/30671>.
> Reported by Ricardo Wurmus <rekado@elephly.net>.
>
> * gnu/packages/video.scm (youtube-viewer)[arguments]: In 'wrap-program'
> phase, add '$out/lib/perl5/site_perl/' to search path.

Applied, thanks!

Ludo’.
L
L
Ludovic Courtès wrote on 7 Mar 2018 02:24
control message for bug #30677
(address . control@debbugs.gnu.org)
87y3j4tc8a.fsf@gnu.org
tags 30677 fixed
close 30677
?
Your comment

This issue is archived.

To comment on this conversation send an email to 30677@patchwise.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 30677
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch