gnu: maths: Fix cache size detected by openblas on some

Done

Details

3 participants

Dave Love
Leo Famulari
Ludovic Courtès

Owner: unassigned

Submitted by: Dave Love

Severity: normal

Debbugs page

Dave Love wrote on 22 Dec 2017 05:13

Recipients:(address . guix-patches@gnu.org)

Message-ID:87r2rm29dy.fsf@albion.it.manchester.ac.uk

This addresses a potential performance problem, fixed in the post-0.2.20
source.  It's intended for application to a package definition updated
to 0.2.20, which Ludo said is in the pipeline.  Apologies that I don't
seem to have converged on an acceptable style for changes.

Attachment: 0001-gnu-maths-Fix-cache-size-detected-by-openblas-on-som.patch

Ludovic Courtès wrote on 8 Jan 2018 01:43

Recipients:(name . Dave Love)(address . fx@gnu.org)(address . 29810@debbugs.gnu.org)

Message-ID:87zi5oit2m.fsf@gnu.org

Hi Dave,

Dave Love <fx@gnu.org> skribis:

Toggle quote (17 lines)> This addresses a potential performance problem, fixed in the post-0.2.20
> source.  It's intended for application to a package definition updated
> to 0.2.20, which Ludo said is in the pipeline.  Apologies that I don't
> seem to have converged on an acceptable style for changes.
>
>>From 23ad3a438ef7bcd34e2354f6cbdede634f0188d4 Mon Sep 17 00:00:00 2001
> From: Dave Love <fx@gnu.org>
> Date: Fri, 22 Dec 2017 12:48:29 +0000
> Subject: [PATCH 1/2] gnu: maths: Fix cache size detected by openblas on some
>  x86_64.
>
> * gnu/packages/patches/openblas-Add-dummy-implementation-of-cpuid_count-for-the-CPUI.patch,
> gnu/packages/patches/openblas-Use-cpuid-4-with-subleafs-to-query-L1-cache-size-on-.patch:
> New files.
> * gnu/packages/maths.scm (openblas)[source]: Use them.
> * gnu/local.mk: Register them.

Thanks for the patch.  Given the number of dependents, we would not push
it in master (info "(guix) Submitting Patches").  At the same time,
since 0.2.20 is in core-updates and well on its way, do you think we
should keep those patches?

Perhaps in core-updates we could keep both 0.2.19 with these patches and
0.2.20 (ISTR you said there were incompatibilities between these two
versions)?  Would it make sense?

Thanks,
Ludo’.

Ludovic Courtès wrote on 11 Jan 2018 01:41

control message for bug #29810

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87lgh4ag1o.fsf@gnu.org

tags 29810 moreinfo

Leo Famulari wrote on 12 Feb 2019 15:21

Re: [bug#29810] gnu: maths: Fix cache size detected by openblas on some

Recipients:

Message-ID:20190212232148.GB31772@jasmine.lan

On Mon, Jan 08, 2018 at 10:43:45AM +0100, Ludovic Courtès wrote:

Toggle quote (9 lines)

> Thanks for the patch. Given the number of dependents, we would not push

> it in master (info "(guix) Submitting Patches"). At the same time,

> since 0.2.20 is in core-updates and well on its way, do you think we

> should keep those patches?

> Perhaps in core-updates we could keep both 0.2.19 with these patches and

> 0.2.20 (ISTR you said there were incompatibilities between these two

> versions)? Would it make sense?

Our openblas package is currently at version 0.3.4. Due to lack of
response from the submitter and the "staleness" of these patches I'm
closing the bug ticket. Please re-open the bug if it is still relevant
to you.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 29810@patchwise.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 29810

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date