livestreamer no longer supported

Done

Details

4 participants

dian_cecht
Oleg Pykhalov
Leo Famulari
Ludovic Courtès

Owner: unassigned

Submitted by: dian_cecht

Severity: normal

Debbugs page

dian_cecht wrote on 4 Jan 2017 08:05

Recipients:(name . bug-guix)(address . bug-guix@gnu.org)

Message-ID:20170104160538.GA10030@khaalida

I just wanted to point out that livestreamer seems to be entirely dead and the
project has been forked. As of this bugreport, the last change was Febuary 2nd,
2016, and while this isn't exactly a long time, considering it no longer works
properly with Twitch.tv (one of, if not the, largest streaming site atm afaik),
gives the impression that it is a dead project.

The fork is named streamlink and is located at https://streamlink.github.io/and
seems to work well.

I'm not sure who is maintaining the livestreamer package, so I'm simply filing
this as a bug here and hope everything is forwarded nicely.

Oleg Pykhalov wrote on 24 Jan 2018 14:17

Recipients:(address . dian_cecht@zoho.com)(address . 25356@debbugs.gnu.org)

Message-ID:87wp06gavu.fsf@gmail.com

Hello,

dian_cecht@zoho.com writes:

Toggle quote (12 lines)> I just wanted to point out that livestreamer seems to be entirely dead and the
> project has been forked. As of this bugreport, the last change was Febuary 2nd,
> 2016, and while this isn't exactly a long time, considering it no longer works
> properly with Twitch.tv (one of, if not the, largest streaming site atm afaik),
> gives the impression that it is a dead project.
>
> The fork is named streamlink and is located at https://streamlink.github.io/ and
> seems to work well.
>
> I'm not sure who is maintaining the livestreamer package, so I'm simply filing
> this as a bug here and hope everything is forwarded nicely.

I got here from

https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00660.html.

The streamlink package is available now from

f48feaa2848d999e100f27301680a01dc3bd7733

Should we still hold livestreamer?

Oleg.

Leo Famulari wrote on 24 Jan 2018 14:27

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)

Message-ID:20180124222737.GA1969@jasmine.lan

On Thu, Jan 25, 2018 at 01:17:09AM +0300, Oleg Pykhalov wrote:

Toggle quote (24 lines)> Hello,
> 
> dian_cecht@zoho.com writes:
> 
> > I just wanted to point out that livestreamer seems to be entirely dead and the
> > project has been forked. As of this bugreport, the last change was Febuary 2nd,
> > 2016, and while this isn't exactly a long time, considering it no longer works
> > properly with Twitch.tv (one of, if not the, largest streaming site atm afaik),
> > gives the impression that it is a dead project.
> >
> > The fork is named streamlink and is located at https://streamlink.github.io/ and
> > seems to work well.
> >
> > I'm not sure who is maintaining the livestreamer package, so I'm simply filing
> > this as a bug here and hope everything is forwarded nicely.
> 
> I got here from
> <https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00660.html>.
> 
> The streamlink package is available now from
> f48feaa2848d999e100f27301680a01dc3bd7733
> 
> Should we still hold livestreamer?

If streamlink is really a continuation of the livestreamer codebase,

then we can mark the livestreamer package as superseded by streamlink.

This will cause the livestreamer package in one's profile to be

automatically replaced by streamlink when doing `guix package

--upgrade`.

Ideally both packages' executables would have the same name.

What do you think?

Oleg Pykhalov wrote on 24 Jan 2018 15:13

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:87k1w6g89l.fsf@gmail.com

Leo Famulari <leo@famulari.name> writes:

[...]

Toggle quote (8 lines)

>> The streamlink package is available now from

>> f48feaa2848d999e100f27301680a01dc3bd7733

>> Should we still hold livestreamer?

> If streamlink is really a continuation of the livestreamer codebase,

> then we can mark the livestreamer package as superseded by streamlink.

Seems it is a fork according to

https://github.com/streamlink/streamlink.

Toggle quote (6 lines)

> This will cause the livestreamer package in one's profile to be

> automatically replaced by streamlink when doing `guix package

> --upgrade`.

> Ideally both packages' executables would have the same name.

Symlink? :-)

From 4f1d5095d15b79d9f90253f6aa67719bcd14918f Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Thu, 25 Jan 2018 02:06:32 +0300
Subject: [PATCH] gnu: livestreamer: Deprecate in favour of streamlink.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/video.scm (livestreamer): Redefine using ‘deprecated-package’.
  (streamlink): Create ‘livestreamer’ symlink.
---
 gnu/packages/video.scm | 36 ++++++++++++------------------------
 1 file changed, 12 insertions(+), 24 deletions(-)

Toggle diff (61 lines)diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index d2599345d..9adc29c3b 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1703,30 +1703,6 @@ pixel motion compensation, lumi masking, trellis quantization, and H.263, MPEG
 and custom quantization matrices.")
     (license license:gpl2+)))
 
-(define-public livestreamer
-  (package
-    (name "livestreamer")
-    (version "1.12.2")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/chrippa/livestreamer/archive/v"
-                    version ".tar.gz"))
-              (file-name (string-append "livestreamer-" version ".tar.gz"))
-              (sha256
-               (base32
-                "1fp3d3z2grb1ls97smjkraazpxnvajda2d1g1378s6gzmda2jvjd"))))
-    (build-system python-build-system)
-    (arguments
-     '(#:tests? #f)) ; tests rely on external web servers
-    (propagated-inputs
-     `(("python-requests" ,python-requests)))
-    (synopsis "Internet video stream viewer")
-    (description "Livestreamer is a command-line utility that extracts streams
-from various services and pipes them into a video playing application.")
-    (home-page "http://livestreamer.io/")
-    (license license:bsd-2)))
-
 (define-public streamlink
   (package
     (name "streamlink")
@@ -1751,11 +1727,23 @@ from various services and pipes them into a video playing application.")
        ("python-iso639" ,python-iso639)
        ("python-pycryptodome" ,python-pycryptodome)
        ("python-requests" ,python-requests)))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-livestreamer-symlink
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Add a `livestreamer' -> `streamlink' link.
+             (let ((out (assoc-ref outputs "out")))
+               (with-directory-excursion (string-append out "/bin")
+                 (symlink "streamlink" "livestreamer"))))))))
     (synopsis "Extract streams from various services")
     (description "Streamlink is command-line utility that extracts streams
 from sites like Twitch.tv and pipes them into a video player of choice.")
     (license license:bsd-2)))
 
+(define-public livestreamer
+  (deprecated-package "livestreamer" streamlink))
+
 (define-public mlt
   (package
     (name "mlt")
-- 
2.15.1

Oleg.

Leo Famulari wrote on 29 Jan 2018 21:01

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)

Message-ID:20180130050126.GA10166@jasmine.lan

On Thu, Jan 25, 2018 at 02:13:42AM +0300, Oleg Pykhalov wrote:

Toggle quote (5 lines)

> Leo Famulari <leo@famulari.name> writes:

> > Ideally both packages' executables would have the same name.

> Symlink? :-)

If streamlink doesn't already provide a 'livestreamer' executable for

compatibility, I'd rather not add one.

It's a matter of taste, but I think we should avoid changing upstream

software for non-technical reasons or without overwhelming user demand

This is in contrast to some distros like Debian which patch their

packages very heavily, basically creating new forks in some cases.

Note that we already had a rather high-profile deprecation with

executable name-change when certbot was renamed from letsencrypt by the

upstream developers. Any users had to adapt their scripts to account for

the new name.

So, my weak preference is to supersede livestreamer with streamlink

without creating the symlink.

Oleg Pykhalov wrote on 29 Jan 2018 23:10

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:87h8r3256a.fsf@gmail.com

Leo Famulari <leo@famulari.name> writes:

[...]

Toggle quote (3 lines)

> So, my weak preference is to supersede livestreamer with streamlink

> without creating the symlink.

Agree. I could merge if see no issues with the following patch.

From fb5bcd6783bf2f2b2b6d0b9e00e471fe51902e7e Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Thu, 25 Jan 2018 02:06:32 +0300
Subject: [PATCH] gnu: livestreamer: Deprecate in favour of streamlink.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/video.scm (livestreamer): Redefine using ‘deprecated-package’.
---
 gnu/packages/video.scm | 27 +++------------------------
 1 file changed, 3 insertions(+), 24 deletions(-)

Toggle diff (47 lines)diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 2d48c5aaf..0788b87f0 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1703,30 +1703,6 @@ pixel motion compensation, lumi masking, trellis quantization, and H.263, MPEG
 and custom quantization matrices.")
     (license license:gpl2+)))
 
-(define-public livestreamer
-  (package
-    (name "livestreamer")
-    (version "1.12.2")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/chrippa/livestreamer/archive/v"
-                    version ".tar.gz"))
-              (file-name (string-append "livestreamer-" version ".tar.gz"))
-              (sha256
-               (base32
-                "1fp3d3z2grb1ls97smjkraazpxnvajda2d1g1378s6gzmda2jvjd"))))
-    (build-system python-build-system)
-    (arguments
-     '(#:tests? #f)) ; tests rely on external web servers
-    (propagated-inputs
-     `(("python-requests" ,python-requests)))
-    (synopsis "Internet video stream viewer")
-    (description "Livestreamer is a command-line utility that extracts streams
-from various services and pipes them into a video playing application.")
-    (home-page "http://livestreamer.io/")
-    (license license:bsd-2)))
-
 (define-public streamlink
   (package
     (name "streamlink")
@@ -1756,6 +1732,9 @@ from various services and pipes them into a video playing application.")
 from sites like Twitch.tv and pipes them into a video player of choice.")
     (license license:bsd-2)))
 
+(define-public livestreamer
+  (deprecated-package "livestreamer" streamlink))
+
 (define-public mlt
   (package
     (name "mlt")
-- 
2.15.1

Thanks,

Oleg.

Leo Famulari wrote on 30 Jan 2018 14:46

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)

Message-ID:20180130224625.GA18810@jasmine.lan

On Tue, Jan 30, 2018 at 10:10:05AM +0300, Oleg Pykhalov wrote:

Toggle quote (20 lines)> Leo Famulari <leo@famulari.name> writes:
> 
> [...]
> 
> > So, my weak preference is to supersede livestreamer with streamlink
> > without creating the symlink.
> 
> Agree.  I could merge if see no issues with the following patch.
> 

> From fb5bcd6783bf2f2b2b6d0b9e00e471fe51902e7e Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Thu, 25 Jan 2018 02:06:32 +0300
> Subject: [PATCH] gnu: livestreamer: Deprecate in favour of streamlink.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> * gnu/packages/video.scm (livestreamer): Redefine using ‘deprecated-package’.

LGTM, thanks!

Oleg Pykhalov wrote on 30 Jan 2018 19:41

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:87lggezod4.fsf@gmail.com

Leo Famulari <leo@famulari.name> writes:

[...]

Toggle quote (12 lines)>> From fb5bcd6783bf2f2b2b6d0b9e00e471fe51902e7e Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Thu, 25 Jan 2018 02:06:32 +0300
>> Subject: [PATCH] gnu: livestreamer: Deprecate in favour of streamlink.
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>> 
>> * gnu/packages/video.scm (livestreamer): Redefine using ‘deprecated-package’.
>
> LGTM, thanks!

Pushed as d84e22578abb75aa5752ed0b41864faab23d338e

Oleg.

Ludovic Courtès wrote on 31 Jan 2018 05:54

control message for bug #25356

Recipients:(address . control@debbugs.gnu.org)

Message-ID:874ln2t9p2.fsf@gnu.org

tags 25356 fixed

close 25356

Your comment

This issue is archived.

To comment on this conversation send an email to 25356@patchwise.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 25356

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date